Skip to content

Fix HTML being rendered in mirror error message

Heinrich Lee Yu requested to merge fix-mirror-status-error-message into master

What does this MR do?

In Rails 6, more String manipulation methods are now HTML-safe aware. https://github.com/rails/rails/pull/33990

This means, when doing the #insert here it first escapes the HTML before inserting into the HTML-safe string

This is similar to !20426 (merged)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports