Apply correct DOMPurify config to work item listing titleHtml
What does this MR do and why?
Follow-up to Use titleHtml where appropriate (!232293 - merged) which standardised rendering work item titles via titleHtml with v-safe-html. It also introduced titleInLinkSafeHtmlConfig, a DOMPurify config that strips <a> tags for contexts where the title is itself rendered as a link.
This MR applies titleInLinkSafeHtmlConfig to both v-safe-html invocations of issuable.titleHtml in IssuableItem, stopping links within the title being themselves included within another link (!), which is pretty confusing.
Screenshots or screen recordings
| Before | After |
|---|---|
|
That's a legit user link you can hover over, and clicking it takes you to that page!!
|
No nested link funny business.
|
How to set up and validate locally
- Create a work item that refers to e.g. a user or another work item in the title (see above screenshots!).
- Go to the work item listing, and hover the title, as well as the link within it; notice the link within it actually links to its destination, rather than the work item!
- Check out this branch.
- Check that link again (should live update in dev wooooo): it should all just link to the work item now, as you'd expect.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.