Skip to content

docs: CI rules: manual does not set 'allowed to fail' automatically

Ben Prescott_ requested to merge bprescott-allowedtofail-20200206 into master

What does this MR do?

I looked into why rules:manual might be causing pipelines to block (internal: slack thread)

Developer noted:

NOTE: Unlike when: manual, rules:manual is implying allow_failure: false by default. We need to explicitly pass allow_failure: true in this case.

Set of tests on gitlab.com:

Related issues

#34077 (closed)

Author's checklist

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Optional: Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Ben Prescott_

Merge request reports