Remove multiple handfuls of wait_for_requests calls
⬅️ Previous MR was Remove a handful of `wait_for_requests` calls (!245555 - merged).⬆️ Part of Remove all uses of `wait_for_requests`, `wait_f... (&22879).➡️ Next MR is Drop another 42 files' worth of `wait_for_reque... (!246008 - merged).
What does this MR do and why?
Remove a bunch of wait_for_requests calls, resulting from a wider run of a harness developed for Remove all uses of `wait_for_requests`, `wait_f... (&22879). See !245555 (merged) for the pilot run.
As with the pilot run, we're only looking at (a) "trivial" sites, where (b) they're the only wait_for_requests call in the whole file. Trivial sites are those where wait_for_requests (which, per &22879, can return at different times at different runs) is immediately followed by a waiting Capybara assertion that checks for what we care about. We can just let that do the waiting, and make headway on excising this flake-encouraging helper from our codebase entirely.
I've checked every site in this MR carefully myself
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.