Skip to content

Vue Labels Select Dropdown

Kushal Pandya requested to merge 198431-vue-labels-dropdown into master

What does this MR do?

This MR introduces a pure Vue implementation of labels select dropdown that can be used for both Issuable sidebar as well as Issue boards. While the changes in this MR may look quite identical with the labels implementation in vue_shared/components/sidebar/labels_select, the key difference between the two as this MR's implementation is not dependent on labels_select.js.

Currently, we use vue_shared/components/sidebar/labels_select implementation in 2 places; Epics sidebar and Issue Boards list creation modal. Once we merge this MR, Epics sidebar will start using the newer implementation that uses GraphQL to fetch and set labels, and in next release, we'll replace Issue Boards usage with newer implementation as well (thus deleting vue_shared/components/sidebar/labels_select entirely).

Screenshots

Visually the implementation doesn't look any different from current labels dropdown.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #198431 (closed)

Edited by Kushal Pandya

Merge request reports