Pass allow_failure: true option to the review jobs for docs
What does this MR do?
Currently, review-docs-deploy and review-docs-cleanup become a blocker to merge MRs because these jobs are marked as allow_failure: false (introduced by !24353 (diffs)). This is because the bug described in #39534 (closed) that rules doesn't make when: manual to be allow_failure: true by default. (whereas when: manual without rules making the job to be allowed to be failed by default)
In fact, our review-deploy and review-stop are using rules already, but also explicitly passing allow_failure: true to make these jobs to be non-blocker.
This MR makes review-docs-deploy and review-docs-cleanup to be allow_failure: true and non-blocker against merges.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team