Skip to content

Add unix to allowed hosts

Patrick Bajao requested to merge pb-add-unix-to-allowed-hosts into master

What does this MR do?

In Rails 6, the new HostAuthorization middleware is enabled by default (it's not enabled on other environments). It currently allows localhost and IP addresses and we add Gitlab.config.gitlab.host as additional allowed host.

When gitlab-shell makes a request via unix socket, it uses http://unix/<endpoint> so the host will be unix. Since it's not included in the list of allowed hosts, it gets blocked.

This adds unix host to the list of allowed hosts.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #199701 (closed)

Merge request reports