Remove FF dap_instance_network_access_controls

Roman Eisnerrequested to merge
re/remove-dap-instance-network-access-controls into master

What does this MR do and why?

Remove FF dap_instance_network_access_controls. No behavior should change, as this FF is default enabled.

References

The SaaS equivalent of this FF was removed in !243118 (merged)

Rollout issue: #595211 (closed)

How to set up and validate locally

Let's try out the settings to ensure nothing broke:

  1. Go into Self-Managed mode: GITLAB_SIMULATE_SAAS: '0' and gdk reconfigure && gdk restart
  2. Go to Duo Instance Settings: Admin > Gitlab Duo > Change configuration - i.e. http://gdk.test:3000/admin/gitlab_duo/configuration
  3. Under "Network access" add a URL to the "Allowlist" (or modify the other settings)
  4. Go to an issue in one of the projects for that TLG, and click "Generate MR with Duo" or tag developer (or start any other flow)
  5. Examine the job log for the flow by going to the flow info
  6. Confirm the TLG settings were used in the job log:

workload___8287____Jobs___GitLab_Duo___Test___GitLab

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Roman Eisner

Merge request reports