Standardize project fabrication on QA Plan tests

What does this MR do?

In some places on QA tests in the Plan stage, when creating a project, we do:

Resource::Project.fabricate_via_api! do |resource|
  resource.name = 'project-name'
end

But in the majority of the tests, we do:

Resource::Project.fabricate_via_api! do |project|
  project.name = 'project-name'
end

So better to stick with one way of doing it for standardization.

This change also goes in line with the convention described here https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/testing_guide/end_to_end/style_guide.md#block-argument-naming.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Walmyr Lima e Silva Filho

Merge request reports

Loading