Remove blocking issues FE feature flag code
What does this MR do?
This MR removes feature flag code for the blocking issues feature which is currently running in production for the gitlab-org/gitlab
project.
MR to remove BE feature flag code (now merged): !24175 (merged)
Issue: #2035 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.8
assigned to @cngo
added 1 commit
- fa763517 - Remove FE :issue_link_types feature flag code
added 1 commit
- 17295c6b - Remove FE :issue_link_types feature flag code
added 1 commit
- 054ac7b1 - Remove FE :issue_link_types feature flag code
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Igor Drozdov ( @igor.drozdov
)Peter Leitzen ( @splattael
)frontend Justin Boyson ( @jboyson
)Mike Greiling ( @mikegreiling
)test Quality for spec/features/*
Walmyr Lima e Silva Filho ( @wlsf82
)No maintainer available Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 6dd58c2a - Remove FE :issue_link_types feature flag code
@sabrams Can you review the backend please?
@ealcantara Can you review the frontend please?
- Resolved by Walmyr Lima e Silva Filho
@wlsf82 Can you review the tests please?
assigned to @sabrams, @ealcantara, and @wlsf82
- Resolved by Coung Ngo
unassigned @sabrams
LGTM @cngo
unassigned @ealcantara
mentioned in merge request !24175 (merged)
assigned to @nick.thomas
unassigned @nick.thomas
added 676 commits
-
6dd58c2a...8b3da021 - 675 commits from branch
master
- 962089f9 - Remove FE :issue_link_types feature flag code
-
6dd58c2a...8b3da021 - 675 commits from branch
mentioned in issue #2035 (closed)
added 28 commits
-
962089f9...d07867ab - 27 commits from branch
master
- fe34dd98 - Remove FE :issue_link_types feature flag code
-
962089f9...d07867ab - 27 commits from branch
unassigned @wlsf82
mentioned in merge request gitlab-com/www-gitlab-com!37108 (merged)
@timzallmann Can you do a maintainer review please?
assigned to @timzallmann
- Resolved by Coung Ngo
- Resolved by Tim Zallmann
@cngo Just one small issue, rest looks good to me and then we can proceed merging.
unassigned @timzallmann
added 480 commits
-
fe34dd98...f46fc221 - 479 commits from branch
master
- 0348e7ce - Remove FE :issue_link_types feature flag code
-
fe34dd98...f46fc221 - 479 commits from branch
added 170 commits
-
0348e7ce...744e7c17 - 169 commits from branch
master
- aaff6347 - Remove FE :issue_link_types feature flag code
-
0348e7ce...744e7c17 - 169 commits from branch
assigned to @timzallmann
Thanks a lot @cngo! Changes look good.
mentioned in commit 56cf2dce
mentioned in merge request !21737 (merged)
removed workflowin review label
added groupproduct planning label and removed 1 deleted label
removed Technical Writing label
added maintenancerefactor label
added typemaintenance label and removed typefeature label