Skip to content

Return nil license if Gitaly is down

Michelle Gill requested to merge 199442-explore-projects into master

What does this MR do?

When exploring projects (/explore, /explore/projects/starred, /explore/projects/trending), a small license icon is displayed for "MIT", "GNU," etc. That license requires a Gitaly call, so if Gitaly is unreachable or down, the entire page will return a 503. This MR should return nil, or an empty license so that the page doesn't require it in order to load.

Screenshots

When Gitaly is available:

Screen_Shot_2020-02-19_at_3.22.08_PM

When Gitaly is unavailable:

Screen_Shot_2020-02-19_at_3.22.47_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #199442 (closed)

Edited by Thong Kuah

Merge request reports

Loading