Make smarter suggestion for assign commands
What does this MR do?
It improves members list filtering to account for different assignees related slash commands. Here are the use-cases it provides;
-
/assign: List only members that are currently not assigned to the Issuable. -
/unassign: List only members that assigned to the Issuable.
Known limitations
This feature relies on Issuable Sidebar Store (a Singleton class) to pull existing assignees on the Issuable, which is already shared with different Vue apps, and the assignees information in the store is updated only when user changes assignees using sidebar dropdown. In case user is using slash commands to update assignees, sidebar currently doesn't reflect it immediately (and requires full page reload) which is an already known limitation. Hence, if dropdown was used to change assignees information, members list suggestion will be inaccurate until page is reloaded. This limitation is currently also affects Label commands.
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #199698 (closed)