Remove dead provides from pipeline tabs app

What does this MR do?

Removes the dead Vue provides from the pipeline details tabs app (app/assets/javascripts/ci/pipeline_details/pipeline_tabs.js) that are safe to remove.

Provide Action Why
codequalityBlobPath Full removal (provide + EE helper method + spec) Injected nowhere. Produced only by an EE js_pipeline_tabs_data helper method (codequality_blob_path) that exists solely to feed it.
codequalityProjectPath Full removal (provide + EE helper method + spec) Same as above (codequality_project_path).
downloadablePathForReportType Full removal (provide + Jest assertion) Phantom: never set by any backend helper, so always undefined.
summaryEndpoint Provide entry only The provide is dead, but the dataset value still feeds the test-reports Vuex store (createTestReportsStore).
suiteEndpoint Provide entry only Same as summaryEndpoint.

codequalityReportDownloadPath and its helper stay (still in use).

Why now?

With the introduction of !242236 (merged) I was able to remove unused injects in our files (this is quite automatic). However, that leaves dangling provides that can't be so easily cleaned up.

How I verified

  • Traced (using !242521 (merged)) each "REMOVABLE" key to its injecting component and confirmed each is a routed descendant of pipeline tabs (kept), while the removed keys are injected nowhere / phantom.
  • yarn eslint clean; rubocop clean on the EE helper.
  • yarn jest green (CE + EE pipeline_tabs specs); rspec ee/spec/helpers/ee/projects/pipeline_helper_spec.rb green (20).
  • Re-ran the trace: the five keys are gone (23 provides now); the six routed-tab keys correctly remain.

Notes for reviewers

Frontend dead-code cleanup that also removes the EE helper plumbing for the two codequality keys; no changelog. Scoped to the one provider file + its EE helper/spec.

Edited by Miguel Rincon

Merge request reports

Loading