Fix incorrect feature flag check
What does this MR do?
Closes #201728 (closed)
For the new sign up flow, we're using invisible captcha. They are behind a feature flag invisible_captcha
.
While we only check for the invisible_captcha
feature flag in the frontend we would activate the feature in the controller when the user was part of the new sign up experiment.
Therefore, we'd have checked in the controller the invisible captcha, although we didn't render it in the frontend when invisible_captcha
was turned off.
No changelog because it is still behind the feature flag experimental_separate_sign_up_flow
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular