Add exclusive guard to ClusterUpdateAppWorker
What does this MR do?
The ClusterUpdateAppWorker calls the Clusters::Applications::PrometheusUpdateService.
If the Clusters::Applications::PrometheusUpdateService is allowed to run multiple times concurrently, it can result in errors caused by multiple helm_api.update statements executing concurrently for the same app. This is because the update works by creating a pod named install-prometheus, which conflicts with any other concurrent update.
The app.make_updating! statement can also result in an error if the application is already in the updating state.
This MR uses the ExclusiveLeaseGuard to ensure that the ClusterUpdateAppWorker cannot be run concurrently for the same app_id.
Issue: #196243 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team