Skip to content

Set SSL certificates path env when calling ES indexer

Changzheng Liu requested to merge omnibus-5037-workaround into master

What does this MR do?

From omnibus-gitlab#5037 (closed),

We tell our users to install custom SSL certificates into /opt/gitlab/embedded/ssl/certs/. These certificates then get picked up by everything in omnibus-gitlab that uses OpenSSL.

It turns out we can tell crypto/tls about /opt/gitlab/embedded/ssl/certs/ by setting SSL_CERT_DIR=/opt/gitlab/embedded/ssl/certs/.

Also, I am proposing to first check the ENV['SSL_CERT_DIR'], then default to /opt/gitlab/embedded/ssl/certs/ if it's not set.

Btw, credits go to @poffey21 , omnibus-gitlab#5037 (comment 279359781)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nick Thomas

Merge request reports