Skip to content

Gracefully handle duplicate artifacts uploads

What does this MR do?

Related to: #199764 (closed)

Related to: #36516 (closed)

This MR allows artifacts upload from Runner to replace existing ones if ActiveRecord::RecordNotUnique is raised.

The RecordNotUnique error is caused by the fact that the Runner had already uploaded the artifact but something went wrong after the artifact has been saved to the database, then Runner retries if it gets 500 Internal Server Error. On the retry, though, the Runner would get ActiveRecord::RecordNotUnique and it would continue to retry.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński (Back 2025-01-01)

Merge request reports

Loading