Return 200 status on duplicate artifacts uploads
What does this MR do?
Related to: #199764 (closed)
Related to: #36516 (closed)
This MR rescues ActiveRecord::RecordNotUnique during artifacts upload by the Runner and returns 200 rather than 500 Internal Server Error. The RecordNotUnique is cause by the fact that the Runner had already uploaded the artifact but something went wrong after the artifact has been saved to the database, then Runner retries if it gets 500 Internal Server Error. On the retry, though, the Runner would get ActiveRecord::RecordNotUnique and it would continue to retry.
Once the artifact has been saved we should return 200.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team