Skip to content

Remove dead code in ide.scss

Himanshu Kapoor requested to merge 27774-ide-scss-remove-dead-code into master

What does this MR do?

Fixes some of the cases in: #27774 (closed)

  1. isZoomable and isZoomed were removed / altered in https://gitlab.com/gitlab-org/gitlab/blob/8a23bcc9bc0f7ab453ee09d41a9407d40d57ba4c/app/assets/javascripts/vue_shared/components/content_viewer/viewers/image_viewer.vue.

  2. .file-content class was removed from image_viewer in https://gitlab.com/gitlab-org/gitlab/blob/f7df9ddb52be8a03b8fbd8c9a870f3e3af577562/app/assets/javascripts/vue_shared/components/content_viewer/viewers/image_viewer.vue, so now the file-content class is only present in download_viewer, and it doesn't contain any img.

  3. .multi-file-discard-btn was removed in 24c84ea6.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports