Skip to content

Allow ImageFormatter#== to factor width and height

What does this MR do?

This change allows two Gitlab::Diff::Positions to be considered not equal when their image position width or height properties are different.

It enables a new GraphQL mutation !24027 (merged) to be able to update just a DiffNote's position.width or position.height properties.

Previously, a change to just the width or height would not be assigned within Notes::UpdateService, as DiffNote#position=(new_position) did not assign new_position when formatter was considered the same and the formatter only compared x and y properties of the position when assessing this.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Luke Duncalfe

Merge request reports