Skip to content

WIP: Refactor project/group variables UI into Vue

Payton Burdette requested to merge ci-variables-ui into master

What does this MR do?

Closing! This MR was broken up into 4 smaller MR's. Which you can view here:

  1. !25260 (merged)

  2. !25263 (merged)

  3. !25468 (merged)

  4. !25731 (merged)

  • Refactors project/group settings CI variables into Vue
  • Moves state management into Vuex store
  • Populates environment scope dropdown from API
  • Variables are now added and edited through a modal to declutter the UI
  • Removes ruby specs and introduces component/store testing

Screenshots

before after
Screen_Shot_2020-02-03_at_3.52.15_PM Screen_Shot_2020-02-03_at_3.53.28_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Payton Burdette

Merge request reports