Skip to content

Geo Node Form in Vue - Selective Sync (Shards)

Zack Cuddy requested to merge 118841_03-node-form-selective-sync-shards into master

Important Notes

This is the an MR broken off of !22719 (closed) This will allow for the MR to be easier to read and review without the giant MR all in one.

Work is towards the goal of #118841 (closed)

What does this MR do?

This MR adds the ability to choose selective sync and the selective sync shards from the Vue Form

Significant Note: The selective sync namespaces will be done in the next MR. Because of this, some functions are intentionally written in a generic way.

This MR works behind the feature flag: :enable_geo_node_form_js

This feature flag will be removed as part of closing #118841 (closed)

This MR itself is an attempt at a MVC as well as to keep the MRs small around this overall change.

The end goal is to transition the Geo Node form into Vue along with additional form validations and updated styles.

Screenshots

Selective Sync - All Selective Sync - Shards Selective Sync - Namespaces (Not implemented in this MR)
before (HAML) All_-_Before Shards_-_Before Namespaces_-_Before
after (JS) All_-_After Shards_-_After Namespaces_-_After

GIFS

Interacting with Selective Sync Shards: Kapture_2020-01-29_at_15.06.59

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports