Remove ai_catalog_flows feature flag from frontend

Eduardo Bonetrequested to merge
29-remove-ai-catalog-flows-ff-frontend into master

What does this MR do and why?

Removes the frontend references to the ai_catalog_flows feature flag, which has been default_enabled: true (beta) since milestone 18.4.

Changes:

  • Remove push_frontend_feature_flag(:ai_catalog_flows, current_user) from 3 controllers
  • Remove gon.features?.aiCatalogFlows conditionals from the catalog and duo_agents_platform JS routers — flows routes are now always registered
  • Remove ?? this.glFeatures.aiCatalogFlows fallback from ai_catalog_nav_tabs.vue
  • Remove expect(response.body).to include('aiCatalogFlows') from 2 request specs

The backend guards (policies, service, helper, FF YAML) will be removed in a follow-up MR.

MR acceptance checklist

  • I have evaluated the MR acceptance checklist for this MR.

Merge request reports