Backport of 'Allow job token basic auth for generic package upload' to 19.0

What does this MR do and why?

Backport of !239076 (merged) to 19-0-stable-ee.

Allows uploading a generic package with a CI job token passed via Basic auth (gitlab-ci-token:$CI_JOB_TOKEN), which previously returned 401 Unauthorized.

The download endpoint has accepted a job token over Basic auth since !138770 (merged), but the upload and Workhorse authorize endpoints still only accepted the job token through the JOB-TOKEN header. This made the documented .netrc/Basic-auth upload flow fail, and contradicted the generic packages documentation.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Tim Rizzi

Merge request reports

Loading