Fix 503 errors caused by Gitaly failures during project_icon lookup
requested to merge 34722-dashboard-projectscontroller-should-tolerate-single-gitaly-node-failure into master
What does this MR do?
Project icon looks up the icon from the repository and uses it if found, but it's causing 503 errors when Gitaly request fails. I think it's reasonable to rescue Gitaly exceptions and display what we can without Gitaly.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Relates to #34722 (closed)
Edited by Sincheol (David) Kim