Skip to content

Support expanding and collapsing embedded charts

Tristan Read requested to merge tr-remove-unfurled-chart into master

What does this MR do?

Adds a button to allow collapsing and expanding embedded charts.

Embedded charts were previously injected onto a hook provided by the backend in gitlab flavored markdown content. This MR groups sibling charts and renders them within a wrapping component, to allow them to be expanded/collapsed together.

Issue: #119210 (closed)

Screenshots

Video In comment thread
embed_charts_demo Screenshot_2020-03-12_at_22.32.38
Multiple charts Collapsed state
Screenshot_2020-03-12_at_22.35.30 hide_embedded_metrics_v12_8

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports