Skip to content

Fix Geo Sidebar missing `active` class

Zack Cuddy requested to merge 199238-fix-designs-sidebar into master

What does this MR do?

Closes #199238 (closed)

Fixes a typo in the controller import that caused the nav_link to not know the controller/view was active

admin/geo/uploads was imported twice, one was intended to be admin/geo/designs. Copy 🍝 mistake

Screenshots

Sidebar (Designs)
before Old
after Screen_Shot_2020-01-28_at_10.52.51_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

cc @fzimmer

Closes #199238 (closed)

Edited by Zack Cuddy

Merge request reports