Skip to content

Add popover to suggest ci pipeline file

Doug Stull requested to merge nudge-to-add-pipeline into master

What does this MR do?

Implements nudge for adding a pipeline if none found as per gitlab-org/growth/ui-ux#62 (closed)

Screenshots

Before change/when pipelines already exist/feature flag off:

Screen_Shot_2020-01-28_at_2.47.43_PM

After change, when no pipelines exist:

Screen_Shot_2020-01-30_at_3.00.50_PM

After change, when no pipelines exist, but it has been dismissed in current session:

Screen_Shot_2020-01-28_at_2.48.58_PM

After change, when scrolling it stays behind tabs/navbar:

Screen_Shot_2020-01-30_at_3.02.31_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Yorick Peterse

Merge request reports