Skip to content

Blacklists project_ci_cd_settings table

Mayra Cabrera requested to merge blacklist-project-ci-cd-settings-table into master

What does this MR do?

Currently project_ci_cd_settings_table table has almost 12 million records in GitLab.com, given its size it should be considered blacklisted from specific operations

From ChatOps

Aggregate  (cost=268260.75..268260.76 rows=1 width=8) (actual time=3628.708..3628.709 rows=1 loops=1)
  Buffers: shared hit=251679 read=13335
  I/O Timings: read=716.724
  ->  Index Only Scan using index_project_ci_cd_settings_on_project_id on project_ci_cd_settings  (cost=0.43..237080.21 rows=12472215 width=0) (actual time=0.136..2692.183 rows=11973442 loops=1)
        Heap Fetches: 682694
        Buffers: shared hit=251679 read=13335
        I/O Timings: read=716.724
Planning time: 1.320 ms
Execution time: 3628.769 ms

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports