Replacing project references with container name in repository classes
What does this MR do?
In !21739 (merged), !23164 (merged), !23494 (merged) we're starting the process of adding repositories to snippets. In this MR, we start replacing the term project
(bound to git related classes like Commit
, Blob
, ...) with container
since now the object of the git object can be also a snippet.
In this MR we refactor the related classes to use this term and we extract some repository related methods to a concern.
Refs #39176 (closed)
Does this MR meet the acceptance criteria?
Conformity
Merge request reports
Activity
changed milestone to %12.8
2 Warnings This merge request is quite big (more than 614 lines changed), please consider splitting it into multiple merge requests. : The merge request title length is acceptable, but please try to reduce it to 50 characters. Commit message standards
The merge request title that will be used in the squash commit does not meet our Git commit message standards.
For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Fabio Pitino ( @fabiopitino
)Rémy Coutable ( @rymai
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- b44e11cc - Replace project references with repositorable
added 1 commit
- eaf7d128 - Replace project references with repositorable
added 1 commit
- ef6e5419 - Replace project references with repositorable
added 61 commits
-
ef6e5419...f5d0c7c5 - 60 commits from branch
master
- 3ae0e5f3 - Replace project references with container
-
ef6e5419...f5d0c7c5 - 60 commits from branch
added 61 commits
-
3ae0e5f3...5fb30b28 - 60 commits from branch
master
- 38685689 - Replace project references with container
-
3ae0e5f3...5fb30b28 - 60 commits from branch
added 66 commits
-
38685689...ab78d4b1 - 65 commits from branch
master
- 39cec0a9 - Replace project references with container
-
38685689...ab78d4b1 - 65 commits from branch
added 104 commits
-
9f4281fb...0ee3c032 - 103 commits from branch
master
- e69b0bed - Replace project references with container
-
9f4281fb...0ee3c032 - 103 commits from branch
The errors exist in master #199216 (closed)
Edited by Francisco Javier López@reprazent sorry to bother you again and flood you with these snippet MRs but you're acquainted with source code and you're up to date with what we want to achieve with snippets. Do you mind to review?
assigned to @reprazent and unassigned @fjsanpedro
- Resolved by Bob Van Landuyt
- Resolved by Bob Van Landuyt
- Resolved by Bob Van Landuyt
- Resolved by Bob Van Landuyt
- Resolved by Francisco Javier López
@fjsanpedro Decoupling
Repository
fromProject
is something I longed for . Nice work!assigned to @fjsanpedro and unassigned @reprazent
@reprazent
for the questions.assigned to @reprazent and unassigned @fjsanpedro
added 85 commits
-
6f69a662...47e09db7 - 84 commits from branch
master
- 6817afa3 - Replace project references with container
-
6f69a662...47e09db7 - 84 commits from branch
added 75 commits
-
b8ca7a25...c01d0411 - 74 commits from branch
master
- 652ed4f0 - Replace project references with container
-
b8ca7a25...c01d0411 - 74 commits from branch
- Resolved by Francisco Javier López
- Resolved by Francisco Javier López
Thanks for explaining @fjsanpedro, replied and resolved!
assigned to @fjsanpedro and unassigned @reprazent
Yours again @reprazent
assigned to @reprazent and unassigned @fjsanpedro
added 72 commits
-
358599cb...a033ad83 - 71 commits from branch
master
- 2b2dc639 - Replace project references with container
-
358599cb...a033ad83 - 71 commits from branch
mentioned in merge request !23796 (merged)
- Resolved by Nick Thomas
@fjsanpedro One more question. But feel free to move it onward for maintainer review after
.
assigned to @fjsanpedro and unassigned @reprazent
- Resolved by Francisco Javier López
@nick.thomas do you mind to review this?
assigned to @nick.thomas and unassigned @fjsanpedro
added 337 commits
-
6e206105...3d9d3567 - 336 commits from branch
master
- ad6015be - Replace project references with container
-
6e206105...3d9d3567 - 336 commits from branch
- Resolved by Nick Thomas
- Resolved by Francisco Javier López
- Resolved by Nick Thomas
- Resolved by Nick Thomas
assigned to @fjsanpedro and unassigned @nick.thomas
@nick.thomas I answered your comments. Thanks for your review!
assigned to @nick.thomas and unassigned @fjsanpedro
added 141 commits
-
ad6015be...254a7ef3 - 140 commits from branch
master
- c16ac6a7 - Replace project references with container
-
ad6015be...254a7ef3 - 140 commits from branch
added 43 commits
-
a11705ba...e01f24f8 - 42 commits from branch
master
- 544c8ba8 - Replace project references with container
-
a11705ba...e01f24f8 - 42 commits from branch
added 68 commits
-
544c8ba8...6180d91a - 67 commits from branch
master
- cbf53d59 - Replace project references with container
-
544c8ba8...6180d91a - 67 commits from branch
added 97 commits
-
cbf53d59...7a281c5d - 96 commits from branch
master
- 13f15b8c - Replace project references with container
-
cbf53d59...7a281c5d - 96 commits from branch
mentioned in commit 9bb098a9
mentioned in issue #201886 (closed)