Skip to content

Fix test runtime ID not working with bin/spring

Matthias Käppler requested to merge 198362-fix-spring-test-detection into master

What does this MR do?

Fixes test runtime ID not working with the bin/spring wrapper.

The problem was that when running under spring, the process name is not rspec anymore. I think we don't need to test the process name anyway, we can instead rely on just Rails.env. The test_suite? method is largely cosmetic anyway, to avoid spamming application logs with failed runtime ID checks, since none of the production runtimes are active in tests.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Assumed behavior:

  • does not break existing runtime checks
  • rspec runs do not log runtime ID check failures
  • bin/spring rspec runs do not log runtime check failures

Closes #198362 (closed)

Edited by Peter Leitzen

Merge request reports