Support the bypass 2FA function with ADFS SAML
requested to merge blunceford/gitlab:35792-saml-bypass-2-factor-authentication-function-does-not-work-with-adfs into master
What does this MR do?
Add support for ADFS SAML Responses for the bypass 2FA function.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
I added an example ADFS SAML Response and test for that response.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #35792 (closed)
Edited by Nick Thomas