Include the full path to an upload in the api response

What does this MR do?

To fetch an upload, a GET request needs to be made to /namespace_path/project_path/:upload_path. This change includes this url in the response returned after making an upload.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• [-] Code review guidelines
• [-] Merge request performance guidelines
• [-] Style guides
• [-] Database guides
• [-] Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• [-] Label as security and @ mention @gitlab-com/gl-security/appsec
• [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• [-] Security reports checked/validated by a reviewer from the AppSec team

#25838 (closed)

added Community contribution label

added api devopsmanage labels

cc/ @lmcandrew

unmarked as a Work In Progress

changed title from {-WIP: Include full_url attribute in Create upload-} response to Include the full path to an upload in the api response

changed the description

added 573 commits

• 00cf819c...b0346d98 - 572 commits from branch gitlab-org:master
• 2cb3be3a - Return the full path to an upload in api response

Compare with previous version

marked the checklist item Changelog entry as completed

changed the description

marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed

added 1 commit

• 5ae8d994 - Return the full path to an upload in api response

Compare with previous version

added 1 commit

• 469eee08 - Return the full path to an upload in api response

Compare with previous version

Hey @Andysoiron. Here's the belated PR; when you have the time.

assigned to @briankabiro

added 2055 commits

• 469eee08...4c94998b - 2054 commits from branch gitlab-org:master
• a1ddcfe6 - Return the full path to an upload in api response

Compare with previous version

added 1 commit

• ffa30774 - Return the full path to an upload in api response

Compare with previous version

added 150 commits

• ffa30774...66acda99 - 149 commits from branch gitlab-org:master
• 45baafb5 - Return the full path to an upload in api response

Compare with previous version

added 1 commit

• 0c98745a - Return the full path to an upload in api response

Compare with previous version

marked the checklist item Documentation (if required) as completed

added 154 commits

• 0c98745a...9bf12de4 - 153 commits from branch gitlab-org:master
• 5ef040fc - Return the full path to an upload in api response

Compare with previous version

added 291 commits

• 5ef040fc...c24a3476 - 290 commits from branch gitlab-org:master
• a39f40d8 - Return the full path to an upload in api response

Compare with previous version

assigned to @Andysoiron and unassigned @briankabiro

Thanks for updating the MR @briankabiro!

I got something wrong when I suggested how to generate the full_path in the entity. Sorry about that! I added a comment and an idea on how to improve the spec

assigned to @briankabiro and unassigned @Andysoiron

added 1 commit

• cd0fb1a8 - Return the full path to an upload in api response

Compare with previous version

added 406 commits

• cd0fb1a8...12daefad - 405 commits from branch gitlab-org:master
• 4c40d036 - Return the full path to an upload in api response

Compare with previous version

added 1 commit

• 04c93846 - Return the full path to an upload in api response

Compare with previous version

Thanks @briankabiro! @DylanGriffith can you do the maintainer review?

assigned to @DylanGriffith and unassigned @briankabiro

approved this merge request

assigned to @briankabiro and unassigned @DylanGriffith

Appreciate the reviews, going to take a look.

added 1 commit

• f38b1225 - Return the full path to an upload in api response

Compare with previous version

added 1 commit

• 55b21837 - Return the full path to an upload in api response

Compare with previous version

resolved all threads

Thanks @briankabiro, this looks good to me

approved this merge request

unapproved this merge request

added 1 commit

• 273c8953 - Return the full path to an upload in api response

Compare with previous version