Loading
GitLab integration test for gitlab-org/gitlab-services/design.gitlab.com!5931
This is a long-lived integration branch for Design updates: integrate Aura design system vi... (gitlab-org/gitlab-services/design.gitlab.com!5931 - merged).
What
- Remove
application_chrome_nav_item.scss, move.with-mouse-over-flyoutstyles tosuper_sidebar.scss - Remove
page_theme_background.scssstyles andpage-theme-backgroundclass fromapplication_helper.rb(and spec) - Remove themes from
super_sidebar.scss - Replace
var(--body-background-color)withbackground-color: var(--gl-application-chrome-background-color) - Remove
var(--body-background-color)definition insuper_sidebar.scss - Remove
--super-sidebar-accent-foreground-colorand usage in.super-sidebar-context-header - Add
@apply gl-shadow-sm;to.paneled-viewinapp/assets/stylesheets/layouts/panel.scss - Remove
--super-sidebar-theme-accent-colorCSS custom property and usage - Remove
aura_tinted_neutral.scsstemporary style overrides
Do not merge this!
Workflow
- Fix pipeline failures in this merge request, if any are needed.
- When ready, get gitlab-org/gitlab-services/design.gitlab.com!5931 (merged) merged.
- Close this merge request.
- Wait for Renovate to create a version bump merge request for
@gitlab/ui. You will automatically be pinged on that merge request and assigned to it. - If you made any fixes in this merge request, cherry-pick them into Renovate's merge request.
- Get that Renovate merge request reviewed and merged.
Commit messages
We should write clear commit messages so we can associate them correctly. For example:
B1: Fix super-sidebar theme colors to old neutrals
- Issue: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/work_items/3444
- MR: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/5902Checks
- The full Jest suite has run (i.e., not just predictive jobs)
- The full Jest suite has passed
- The full RSpec suite has run (i.e., not just predictive jobs)
- The full RSpec suite has passed
After gitlab-org/gitlab-services/design.gitlab.com!5931 (merged) merges
- Close this merge request.
- Cherry-pick fixes from here to Renovate's merge request.
Edited by Scott de Jonge