Skip to content

Refactoring: Move "Credential inventory" to a re-usable concern

What does this MR do?

We currently have Credentials inventory at the Instance level: #36742 (closed)

With #38133 (closed), we are trying to build this at the Group level too, for groups that supports managed accounts.

Since the controller actions and much of the methods would be the same for both of these, we could reuse the methods for both these places and as a first step towards implementing #38133 (closed), I'm moving our current methods to a concern and views to the shared folder.

Since this change is just refactoring, I am depending on the already existing specs, including feature specs for this feature to make sure the changes are right.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Manoj M J

Merge request reports