Enable let_it_be freeze modifier in Geo specs (batch 12/13)

Nishant sanjay boruderequested to merge
gitlab-community/gitlab-org/gitlab:597552-let-it-be-freeze-geo-batch-12-13 into master

Description

What does this MR do and why?

Adds freeze: true to let_it_be declarations in Geo specs for batch 12/13, following the rollout issue guidance.

This helps prevent mutable shared test state and catches mutation patterns earlier, improving test isolation and reducing flaky behavior.

Related issue:

Files updated

  • ee/spec/services/geo/graphql_request_service_spec.rb
  • ee/spec/services/geo/metrics_update_service_spec.rb
  • ee/spec/services/geo/node_status_request_service_spec.rb
  • ee/spec/services/geo/node_update_service_spec.rb
  • ee/spec/services/geo/primary_api_request_service_spec.rb
  • ee/spec/services/geo/replication_toggle_request_service_spec.rb
  • ee/spec/services/geo/sync_service_spec.rb
  • ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb
  • ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb
  • ee/spec/support/shared_examples/lib/geo/console_shared_examples.rb

How to set up and validate locally

  1. Run focused specs:

    bundle exec rspec \
  ee/spec/services/geo/graphql_request_service_spec.rb \
  ee/spec/services/geo/metrics_update_service_spec.rb \
  ee/spec/services/geo/node_status_request_service_spec.rb \
  ee/spec/services/geo/node_update_service_spec.rb \
  ee/spec/services/geo/primary_api_request_service_spec.rb \
  ee/spec/services/geo/replication_toggle_request_service_spec.rb \
  ee/spec/services/geo/sync_service_spec.rb \
  ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb \
  ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb \
  ee/spec/support/shared_examples/lib/geo/console_shared_examples.rb

  2. Confirm no formatting issues:

    git diff --check

Merge request reports