Retry set_latest_merge_request_diff_ids!
What does this MR do?
This MR implement the issue #39107 (closed)
MR !22265 (merged) add retry action for relation_object.save!.
There is another database save could have similar retriable failure, and this MR is to add retry action for it:
# lib/gitlab/import_export/project_tree_restorer.rb:24
@project.merge_requests.set_latest_merge_request_diff_ids!Currently, import_failures table does not save the information about which import action generates failure. Initially, the table was designed to save import failures only for build relation action.
Now we want to use the same table to save exceptions from
merge_requests.set_latest_merge_request_diff_ids! action. So we add a
new column to record the action.
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Relates #39107 (closed)