Skip to content

Refactor WebIDE error message to use GlAlert

Sean Nichols requested to merge seanich/gitlab:36854-webide-use-gl-alert into master

What does this MR do?

Rewrite the template used in the WebIDE error-message component to make use of GlAlert from @gitlab/ui. This change also resolves the broken looking action link referenced in #36852 (closed).

Screenshots

State Before After
Error message without action, dismissible (Note: this is a contrived example as setErrorMessage is never dispatched without an action property) Screen_Shot_2020-01-19_at_15.38.07 Screen_Shot_2020-01-19_at_15.37.28
Error message with action Screen_Shot_2020-01-19_at_15.19.57 Screen_Shot_2020-01-19_at_15.19.01
Error message with action (loading) Screen_Shot_2020-01-19_at_15.23.49 Screen_Shot_2020-01-19_at_15.25.17

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #36854 (closed) and #36852 (closed)

Edited by Sean Nichols

Merge request reports