Skip to content

Enable Rails rubocops

Ryan Cobb requested to merge rc/enable_rails_cops into master

What does this MR do?

This MR enables the following rubocops as part of #42182 (closed)

Rubocops enabled and applied to current codebase:

  • Rails/SafeNavigationWithBlank,
  • Rails/EnumHash
  • Style/MutableConstant

Rubocops enabled that ignore current codebase but will apply to future changes:

  • Rails/ApplicationController
  • Rails/ApplicationMailer
  • Rails/RakeEnvironment
  • Rails/HelperInstanceVariable

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports