Skip to content

WIP: Extract artifacts upload into service

Fabio Pitino requested to merge group-artifact-creation into master

What does this MR do?

Introduce a service class Ci::UploadArtifactsService that takes all the complexity out of the Runner's POST /:id/artifacts API endpoint.

This moves some domain knowledge from the application layer down to the domain layer.

TODO

  • write specs for service class
  • write specs for new job.max_artifacts_size method

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports