Backport of 'Fix runner token reset returning 500 for unassigned project runners' to 18.10

What does this MR do and why?

Backport of !227077 (merged) to the 18-10-stable-ee branch.

Original MR: !227077 (merged)

When a project-type runner that is not assigned to any project attempts to rotate its authentication token, an unhandled ActiveRecord::RecordInvalid exception produces an HTTP 500. This backport applies the fix that rescues the exception and returns a 422 Unprocessable Entity instead.

Closes #592412 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, reach out to a Software Engineer in Test in #s_developer_experience.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Pedro Pombeiro

Merge request reports

Loading