Backported of Fix remaining failures in new_project_spec.rb after !228726
What does this MR do and why?
This backports !229301 (merged) to 18-8-stable-ee.
The original MR fixes two flaky test failures in ee/spec/features/projects/new_project_spec.rb:
creates a new project in personal namespace-Project.lastwas called before the page finished navigating, returningnil. Fixed by waiting for the URL to match the user's namespace path first.creates CI/CD project from GitHub- The "Continue import" button was clicked before the async GitHub import status poll resolved. Fixed by addingwait_for_requestsbetween the two clicks.
Related to https://gitlab.com/gitlab-org/quality/test-failure-issues/-/work_items/39604
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
e2e:test-on-omnibus-eejob has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, reach out to a Software Engineer in Test in #s_developer_experience.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.