Skip to content

Finalise Container registry expiration policy settings app

Nicolò Maria Mezzopera requested to merge 15398-finalise-settings-app into master

What does this MR do?

This MR finalizes the work around the expiration policy settings app by:

  • Add select all tags copy in the legend of the text-area
  • Rename some labels
  • wiring the API in 'read' and 'update'
  • adding a base feature test that covers saving the form thus testing both interface and API

⚠ This MR is behind feature flag ⚠

What does this MR do not do?

This MR does not align the miss-alignment from the design system since we are only using and composing gitlab-ui components this is going to be taken care in pajama / gitlab-ui

Screenshots

Before this MR

Before

After this MR

Screenshot_2020-01-14_at_13.57.30

Screencapture

screen-capture__9_

Notes

Hey! that is a big loader replacing the form while the data is being saved/fetched!

Yes, sadly there is some bleeding jQuery js that is otherwise disabling the submit button and so we need to un-mount and remount the vue component to remove any jquery side effects, I still need to catch the culprit but I will open a separate issue as I suspect that the change will be of bigger scope.

!22992 (merged)

Update: the MR is now merged, but the work around the loader is going to be done in another MR along other minor Ui / copy changes, luckily this is behind a feature flag

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Part of #15398 (closed)

Edited by Yorick Peterse

Merge request reports