Add blob and blob_viewer fields to graphql snippet type

changed milestone to %12.7

added backend devopscreate groupeditor [DEPRECATED] + 1 deleted label

changed the description

added 1 commit

d112e106 - Add blob viewer field to graphql snippet type

	2 Warnings
	This merge request is quite big (more than 701 lines changed), please consider splitting it into multiple merge requests.
	f34fc09e: The commit subject length is acceptable, but please try to reduce it to 50 characters.

Commit message standards

The commit message that will be used in the squash commit does not meet our Git commit message standards.

For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.

Here is an example of a good commit message:

Reject ruby interpolation in externalized strings

When using ruby interpolation in externalized strings, they can't be
detected. Which means they will never be presented to be translated.

To mix variables into translations we need to use `sprintf`
instead.

Instead of:

    _("Hello #{subject}")

Use:

    _("Hello %{subject}") % { subject: 'world' }

This is an example of a bad commit message:

updated README.md

This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Gabriel Mazetto (`@brodock`)	Heinrich Lee Yu (`@engwan`)

Generated by Danger

marked the checklist item Changelog entry as completed

@jprovaznik do you mind to review this MR?

assigned to @jprovaznik and unassigned @fjsanpedro

added typefeature label

added feature label just now

I added this because bot complains about missing throughput label and because this adds a new field to API, I think feature is a good fit.

approved this merge request

Thanks @fjsanpedro, LGTM (one nit about changelog), please assign to a maintainer then (I think this was first review, right?).

assigned to @fjsanpedro and unassigned @jprovaznik

resolved all threads

added 203 commits

d112e106...39a356f4 - 202 commits from branch master
0b47476b - Add blob viewer field to graphql snippet type

Compare with previous version

Thanks @jprovaznik for the review!. I addressed the comment.

Yes, this was the first round of review. @reprazent do you mind to take the maintainer review?

assigned to @reprazent and unassigned @fjsanpedro

@fjsanpedro I understand this is targeted at us as the primary consumer. But I'm having a bit of a hard time understanding how this feature is going to work for us in vue.

Don't we want a way for the consumers to request the blob's content, perhaps with a description of how to render it.

The BlobViewerType currently includes a bunch of internal information that I don't understand how the client will use for the vue refactor. Could you perhaps link me to the issue where this was discussed with frontend?

assigned to @fjsanpedro and unassigned @reprazent

added 1 commit

dfbacb67 - Add blob viewer field to graphql snippet type

Compare with previous version

@reprazent I addressed your comments. The only thing left is the concern about users. If there were some short internal Graphql API this endpoint would be perfect for it. Nevertheless, we don't have it, we need this in order to avoid duplicities in FE (big ones in this case), and, INMHO, since it's GraphQL and we don't send all the information at once, I believe we're ok adding this endpoint. If any client other than us use it, then they won't be able to do much with it.

assigned to @reprazent and unassigned @fjsanpedro

added 1 commit

6feaf1ec - Add blob viewer field to graphql snippet type

Compare with previous version

@fjsanpedro I understand better now. It's just not clear right now how the frontend will actually get to the content of a snippet. What do you think of my suggestion in !22960 (comment 272659984)

I'm fine with waiting until the frontend requests that as well, but then maybe we should only expose content_html correctly for now .