Skip to content

Abstract out MarkAsSpamService

charlie ablett requested to merge cablett-spam-tidy-mark-spam-service into master

What does this MR do?

Part of a general tidying of spam logic.

This MR abstracts out Mark As Spam logic into its own service.

SpamService was doing too much and it was a source of confusion. This helps to clarify and decouple these similar but distinct services.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #196157 (closed)

Edited by charlie ablett

Merge request reports