Scrollable design view (#13217 part 1)
What does this MR do?
Updates the layout of the Design view such that design-presentation component is capable of overflowing.
In this MR, the only user-facing change is the addition of 16px of padding at the bottom of the design image for larger images (see screenshots below). This (inadvertently) appears to fix a bug where the bottom of larger images were previously not visible. Notice that even with the addition of the padding, the blue comment pins remain in the correct position.
design-presentation-component and depends on !22852 (merged) being merged.
Context
We originally wanted to enable scrolling by default for larger images i.e. when an image height > width, we would let the image overflow vertically (work captured in !22857 (closed)). It was decided to not use this behaviour for the time being and instead retain the existing behaviour.
The changes in this MR are arguably still an improvement (and essential for !22863 (merged)), hence why it exists!
Screenshots
Screenshots added to demonstrate that existing behaviour is retained.
| Current behaviour | Behaviour with this MR applied |
|---|---|
| Desktop (small image) | Desktop (small image) |
 |
 |
| Desktop (large image) | Desktop (large image) |
 |
 |
| Mobile | Mobile |
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content