Optimize factory usage for integrations edit

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-integrations-edit into master

What does this MR do and why?

This MR replaces create with build_stubbed in spec/views/projects/settings/integrations/edit.html.haml_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec spec/views/projects/settings/integrations/edit.html.haml_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 1.678s (8.51% of total time)

After optimization:

  • Factory time: 0.042s (0.22% of total time)

🚀 Improvement:

  • Factory time reduced by: 1.636s
  • Factory time percentage reduced by: 8.29%
  • Overall factory usage improvement: 97.5%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache

Test environment set up in 1.276157999993302 seconds
..[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 2
Total wasted time: 00:01.647

projects/settings/integrations/edit (./spec/views/projects/settings/integrations/edit.html.haml_spec.rb:5) (8 records created, 00:01.647)
  is expected not to have text "Recent events" (./spec/views/projects/settings/integrations/edit.html.haml_spec.rb:14) – 4 records created, 00:01.324
  is expected to have text "Recent events" (./spec/views/projects/settings/integrations/edit.html.haml_spec.rb:25) – 4 records created, 00:00.322




Finished in 15.59 seconds (files took 14.14 seconds to load)
2 examples, 0 failures

Randomized with seed 48479

[TEST PROF INFO] Time spent in factories: 00:01.655 (8.35% of total time)

Factory time before the update 

[TEST PROF INFO] Time spent in factories: 00:01.678 (8.51% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.042 (0.22% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports