Optimize factory usage for pages domains show

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-pages-domain-show into master

What does this MR do and why?

This MR replaces create with build_stubbed in spec/views/projects/pages_domains/show.html.haml_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec spec/views/projects/pages_domains/show.html.haml_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 2.77s (12.68% of total time)

After optimization:

  • Factory time: 0.065s (0.36% of total time)

🚀 Improvement:

  • Factory time reduced by: 2.705s
  • Factory time percentage reduced by: 12.32%
  • Overall factory usage improvement: 97.7%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache

Test environment set up in 1.2269569999771193 seconds
....[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 4
Total wasted time: 00:02.585

projects/pages_domains/show (./spec/views/projects/pages_domains/show.html.haml_spec.rb:5) (16 records created, 00:02.585)
  shows verification warning (./spec/views/projects/pages_domains/show.html.haml_spec.rb:13) – 4 records created, 00:01.377
  shows alert about time of obtaining certificate (./spec/views/projects/pages_domains/show.html.haml_spec.rb:23) – 4 records created, 00:00.402
  shows verification warning (./spec/views/projects/pages_domains/show.html.haml_spec.rb:13) – 4 records created, 00:00.416
  shows alert about time of obtaining certificate (./spec/views/projects/pages_domains/show.html.haml_spec.rb:23) – 4 records created, 00:00.388




Finished in 15.29 seconds (files took 13.73 seconds to load)
4 examples, 0 failures

Randomized with seed 8618

[TEST PROF INFO] Time spent in factories: 00:02.592 (13.36% of total time)

Factory time before the update 

[TEST PROF INFO] Time spent in factories: 00:02.770 (12.68% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.065 (0.36% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports