Skip to content

WIP: Update attach file and loading icon with GitLab SVGs and gl-loading-icon

Jarek Ostrowski requested to merge update-attach-file-icon into master

What does this MR do?

Replaces the Attach a file Font Awesome icons with our own GitLab SVGs. That includes replacing the Font Awesome loading icon with the new GitLab loading icon.

Attach Attaching
attach attaching

Important note - Instead of hide class, I replaced with hidden. That's because I used d-flex classes which use the conflicting display property. d-flex makes it easy to align icons, text, and buttons vertically, so that's why some parent divs contain d-flex align-items-center.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jarek Ostrowski

Merge request reports