Optimize factory usage for cluster serializer

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-cluster-serializer-spec into master

What does this MR do and why?

This MR replaces create with build_stubbed in spec/serializers/cluster_serializer_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec spec/serializers/cluster_serializer_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 2.26s (3.0% of total time)

After optimization:

  • Factory time: 0.18s (1.08% of total time)

🚀 Improvement:

  • Factory time reduced by: 2.08s
  • Factory time percentage reduced by: 1.92%
  • Overall factory usage improvement: 92.0%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache

Test environment set up in 1.3327550000103656 seconds
...[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 3
Total wasted time: 00:02.533

ClusterSerializer (./spec/serializers/cluster_serializer_spec.rb:5) (25 records created, 00:02.533)
  serializes attrs correctly (./spec/serializers/cluster_serializer_spec.rb:11) – 6 records created, 00:01.522
  serializes attrs correctly (./spec/serializers/cluster_serializer_spec.rb:36) – 13 records created, 00:00.551
  serializes attrs correctly (./spec/serializers/cluster_serializer_spec.rb:42) – 6 records created, 00:00.460




Finished in 13.91 seconds (files took 15.79 seconds to load)
3 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:02.540 (13.78% of total time)

Factory time before the update 

[TEST PROF INFO] Time spent in factories: 00:02.260 (3.0% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.180 (1.08% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports